fix: use permanent backoff when stacker set not found #5104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will this cause issues in the prepare phase though when it has not yet been calculated? I see that the "tests::signer::v0::reloads_signer_set_in" test is failing now. |
kantai
previously approved these changes
Sep 17, 2024
obycode
previously approved these changes
Sep 17, 2024
Co-authored-by: Brice Dobry <[email protected]>
|
LGTM! I can't review as it's my PR, but thank you @kantai for fixing this! |
obycode
approved these changes
Sep 17, 2024
kantai
approved these changes
Sep 17, 2024
jcnelson
approved these changes
Sep 17, 2024
|
Marking as "merge when ready" -- the failing tests all pass locally. Two of these flaky tests (which are already flaky in develop) I think I have fixes for, so will open a PR to fix them soon. |
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the signer fetches the stacker set for a cycle, and the response is "not found" (because there isn't a PoX anchor block yet), a "permanent" error is returned instead of "transient". This will exit the exponential backoff function that would previously retry this request until the max timeout (5 seconds) was reached.