Fix/5136 node and miner #5138
Fix/5136 node and miner #5138
Conversation
…the proposed block builds on a canonical tenure, and it builds on the highest known block in that tenure
…ion test for verifying that it works
Signed-off-by: Jacinta Ferrant <[email protected]>
…he same block Signed-off-by: Jacinta Ferrant <[email protected]>
…lock header in a tenure
…etwork/stacks-core into fix/5136-signer-block-state-tracking
Signed-off-by: Jacinta Ferrant <[email protected]>
…. Also, add serde round-trip test
Signed-off-by: Jacinta Ferrant <[email protected]>
…ortition being processed
….com/stacks-network/stacks-blockchain into fix/5136-signer-block-state-tracking
…diately on burncahin tip change
|
This LGTM, but there are a lot of failing integration tests on this PR. I think those need to be resolved before merging. |
…achine Fix/signer block state machine
* these tests work fine locally, but in CI, they just timeout after 30 minutes without any logging
There was a problem hiding this comment.
The integration tests all pass now.
There remain a handful of flaky tests that often need reruns in CI. That can be investigated separately from this PR, I think. Two tests pass locally just fine but always timeout in CI without any logging information. Those tests are disabled for now, but really should be investigated.
Signed-off-by: Jacinta Ferrant <[email protected]>
There was a problem hiding this comment.
The integration tests all pass now.
There remain a handful of flaky tests that often need reruns in CI. That can be investigated separately from this PR, I think. Two tests pass locally just fine but always timeout in CI without any logging information. I'm pretty sure its a CI issue -- disabling those two tests causes two other tests to instead exhibit the same behavior. So, it seems like it must be something weird is happening (deterministically) when it comes to executor assignment for those two tests?
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This fixes the node and miner code paths for #5136. It makes it so that the miner will never time out waiting for signatures, and makes it so that the block validation endpoint checks that the proposed block builds on a canonical tenure, and builds on an acceptably-high block in that tenure.
Leaving as a draft for now until integration tests pass, and until additional unit test coverage can be added.