Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for flashblocks when epoch 3 is deployed #5154

Merged
merged 14 commits into from
Sep 23, 2024
Merged

Add test for flashblocks when epoch 3 is deployed #5154

merged 14 commits into from
Sep 23, 2024

Conversation

ASuciuX
Copy link
Contributor

@ASuciuX ASuciuX commented Sep 9, 2024

related issue #5127

@ASuciuX ASuciuX requested a review from obycode September 9, 2024 15:45
@ASuciuX ASuciuX self-assigned this Sep 9, 2024
@ASuciuX ASuciuX requested a review from a team as a code owner September 9, 2024 15:45
jcnelson
jcnelson previously approved these changes Sep 18, 2024
View reviewed changes
obycode
obycode requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Please also add this new test to .github/workflows/bitcoin-tests.yml so that it will run in CI.

@ASuciuX ASuciuX requested a review from a team as a code owner September 18, 2024 14:03
@ASuciuX
Copy link
Contributor Author

ASuciuX commented Sep 18, 2024

This looks good. Please also add this new test to .github/workflows/bitcoin-tests.yml so that it will run in CI.

Done, thanks!

obycode
obycode requested changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new test is failing in CI. Please investigate.

@ASuciuX
Copy link
Contributor Author

ASuciuX commented Sep 18, 2024

This new test is failing in CI. Please investigate.

Thanks for pointing it out, looks like on CI it works differently than locally, as on my end it works. I will look into what could be the difference that makes another block missing (error here).

obycode
obycode approved these changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wileyj wileyj added this pull request to the merge queue Sep 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 23, 2024
@wileyj wileyj added this pull request to the merge queue Sep 23, 2024
Merged via the queue into develop with commit 7b1d72d Sep 23, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@obycode obycode obycode approved these changes

@wileyj wileyj wileyj approved these changes

@jcnelson jcnelson jcnelson left review comments

@jferrant jferrant Awaiting requested review from jferrant

Assignees

@ASuciuX ASuciuX

Labels
3.0-must 3.0-Testing locked
Projects
Stacks Core Eng
Status: Status: ✅ Done
Milestone
Nakamoto 3.0 - Testnet Readiness
Development

Successfully merging this pull request may close these issues.
6 participants
@ASuciuX @blockstack-devops @jcnelson @obycode @wileyj @saralab