Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs and defaults #5170

Merged
4 commits merged into from
Sep 16, 2024
Merged

Logs and defaults #5170

4 commits merged into from
Sep 16, 2024

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Sep 12, 2024

  • Add more signer logs for help with debugging.
  • Change default nakamoto_attempt_time_ms to 5s (from 20s)

@obycode obycode requested review from a team as code owners September 12, 2024 17:17
@obycode obycode requested a review from kantai September 12, 2024 17:17
jferrant
jferrant previously approved these changes Sep 12, 2024
This matches the hard-coded timeout what was previously in the code.
@obycode
Copy link
Contributor Author

obycode commented Sep 16, 2024

  • tests::signer::v0::bitcoind_forking_test passes locally
  • tests::signer::v0::partial_tenure_fork passes locally
    I opened Test out nakamoto_attempt_time_ms at 60s #5189 to test out if these tests pass in CI when that parameter is reverted back to 20s.

@obycode
Copy link
Contributor Author

obycode commented Sep 16, 2024

I can see how 5s might not be long enough on these CI runners for a Nakamoto block to be mined. That could definitely cause partial_miner_tenure to fail. It may actually make sense to bump this up to 60s in CI. I will try that out after checking the results of the 20s test.

@github-merge-queue github-merge-queue bot closed this pull request by merging all changes into develop in 56ce7d5 Sep 16, 2024
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants