Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add debug logs before all stacks_node_client use #5179

Merged
merged 5 commits into from
Sep 16, 2024

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Sep 13, 2024

More logs to help with triaging issues.

@obycode obycode requested a review from a team as a code owner September 13, 2024 18:29
@obycode
Copy link
Contributor Author

obycode commented Sep 13, 2024

@hstove I was noticing the timers present on some of these calls. Do we want to add it to the others as well, or there a specific subset that you were targeting?

jcnelson
jcnelson previously approved these changes Sep 13, 2024
@jferrant
Copy link
Collaborator

Am seeing some build issues.

jferrant
jferrant previously approved these changes Sep 13, 2024
hstove
hstove previously approved these changes Sep 15, 2024
@obycode obycode dismissed stale reviews from hstove and jferrant via 2813f3d September 15, 2024 19:35
jcnelson
jcnelson previously approved these changes Sep 15, 2024
@wileyj
Copy link
Contributor

wileyj commented Sep 16, 2024

@obycode some merge conflicts, saving approval for when those are fixed

@obycode
Copy link
Contributor Author

obycode commented Sep 16, 2024

Resolved.

@saralab saralab self-requested a review September 16, 2024 13:50
Copy link
Member

@CharlieC3 CharlieC3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@obycode obycode added this pull request to the merge queue Sep 16, 2024
Merged via the queue into develop with commit 319e93b Sep 16, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants