Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that stackerdb is set before configuring the signer #5198

Merged
merged 3 commits into from
Sep 17, 2024

Conversation

jferrant
Copy link
Collaborator

@jferrant jferrant commented Sep 17, 2024

Closes #5195

Signers were sometimes loading their stackerdb configuration too quickly before it had time to update. This ensures that a signer does not configure themselves before the stackerdb config is updated.

@jferrant jferrant requested a review from a team as a code owner September 17, 2024 02:22
…off to prevent waiting needlessly for a burn block

Signed-off-by: Jacinta Ferrant <[email protected]>
hstove
hstove previously approved these changes Sep 17, 2024
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

jcnelson
jcnelson previously approved these changes Sep 17, 2024
@kantai kantai dismissed stale reviews from jcnelson and hstove via 9b09f0b September 17, 2024 15:29
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kantai kantai added this pull request to the merge queue Sep 17, 2024
Merged via the queue into develop with commit 3d04553 Sep 17, 2024
1 check passed
@hstove hstove deleted the bugfix/5195-signers-stackerdb-config branch September 17, 2024 18:47
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants