-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: limit number of UTXOs retrieved with listunspent
#5201
Conversation
This prevents the response from being too large and exceeding the 16MB limit that we support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was going to make this configurable so we could test it in an integration test
Ah okay. Yeah, I can do that. |
@jcnelson the config option and test have been added. |
This causes a problem in CI.
Ah, then it's fine where it is in burnchain
…On Tue, Sep 17, 2024, 5:21 PM Brice Dobry ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In testnet/stacks-node/src/config.rs
<#5201 (comment)>
:
> @@ -1446,6 +1446,10 @@ pub struct BurnchainConfig {
/// fault injection to simulate a slow burnchain peer.
/// Delay burnchain block downloads by the given number of millseconds
pub fault_injection_burnchain_block_delay: u64,
+ /// The maximum number of unspent UTXOs to request from the bitcoin node.
+ /// This value is passed as the `maximumCount` query option to the
+ /// `listunspent` RPC call.
+ pub max_unspent_utxos: Option<u64>,
All of the other miner-specific burnchain options are also in
BurnchainConfig, e.g. rbf_fee_increment, max_rbf, etc.
—
Reply to this email directly, view it on GitHub
<#5201 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AADQJK6V6IWBPPWIUH5SM2DZXCMNRAVCNFSM6AAAAABOL2BZBCVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMJRGA4TGMBZGY>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This prevents the response from being too large and exceeding the 16MB limit that we support.