Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: limit number of UTXOs retrieved with listunspent #5201

Merged
merged 4 commits into from
Sep 18, 2024
Merged

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Sep 17, 2024

This prevents the response from being too large and exceeding the 16MB limit that we support.

This prevents the response from being too large and exceeding the 16MB
limit that we support.
@obycode obycode requested a review from a team as a code owner September 17, 2024 16:07
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to make this configurable so we could test it in an integration test

@obycode
Copy link
Contributor Author

obycode commented Sep 17, 2024

I was going to make this configurable so we could test it in an integration test

Ah okay. Yeah, I can do that.

@obycode
Copy link
Contributor Author

obycode commented Sep 17, 2024

@jcnelson the config option and test have been added.

@obycode obycode requested a review from a team as a code owner September 17, 2024 20:05
This causes a problem in CI.
@jcnelson
Copy link
Member

jcnelson commented Sep 17, 2024 via email

@obycode obycode added this pull request to the merge queue Sep 18, 2024
Merged via the queue into develop with commit 0146ba2 Sep 18, 2024
1 check passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants