Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2.5.0.0.7 rbf logic #5209

Merged
merged 7 commits into from
Sep 19, 2024
Merged

Fix/2.5.0.0.7 rbf logic #5209

merged 7 commits into from
Sep 19, 2024

Conversation

wileyj
Copy link
Contributor

@wileyj wileyj commented Sep 18, 2024

Hotifx

@wileyj wileyj requested a review from a team as a code owner September 18, 2024 19:43
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a unit test?

@jcnelson jcnelson self-requested a review September 18, 2024 20:01
jcnelson
jcnelson previously approved these changes Sep 18, 2024
@wileyj
Copy link
Contributor Author

wileyj commented Sep 18, 2024

will add the test in a few, it's on a different branch in #5210

obycode
obycode previously approved these changes Sep 18, 2024
@wileyj wileyj dismissed stale reviews from obycode and jcnelson via 89c1414 September 18, 2024 20:07
@wileyj wileyj requested a review from a team as a code owner September 18, 2024 20:07
obycode
obycode previously approved these changes Sep 18, 2024
obycode
obycode previously approved these changes Sep 18, 2024
@wileyj
Copy link
Contributor Author

wileyj commented Sep 19, 2024

all failing tests are passing locally (even the flaky one)

@wileyj wileyj merged commit 96efb61 into release/2.5.0.0.8 Sep 19, 2024
118 of 121 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants