Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make chain_id configurable #5300

Merged
merged 11 commits into from
Oct 14, 2024
Merged

feat: make chain_id configurable #5300

merged 11 commits into from
Oct 14, 2024

Conversation

obycode
Copy link
Contributor

@obycode obycode commented Oct 10, 2024

Description

Applicable issues

  • fixes #

Additional info (benefits, drawbacks, caveats)

Checklist

  • Test coverage for new or modified code paths
  • Changelog is updated
  • Required documentation changes (e.g., docs/rpc/openapi.yaml and rpc-endpoints.md for v2 endpoints, event-dispatcher.md for new events)
  • New clarity functions have corresponding PR in clarity-benchmarking repo
  • New integration test(s) added to bitcoin-tests.yml

@obycode obycode requested a review from a team as a code owner October 10, 2024 18:03
jferrant
jferrant previously approved these changes Oct 10, 2024
kantai
kantai previously approved these changes Oct 10, 2024
Error if an unknown field is found in a node's config file. This is
helpful to catch errors in the config file.
@obycode obycode dismissed stale reviews from kantai and jferrant via 8f9efb9 October 10, 2024 18:32
jferrant
jferrant previously approved these changes Oct 10, 2024
@obycode obycode requested a review from a team as a code owner October 10, 2024 19:16
kantai
kantai previously approved these changes Oct 10, 2024
jferrant
jferrant previously approved these changes Oct 10, 2024
@obycode obycode dismissed stale reviews from jferrant and kantai via a3f3230 October 10, 2024 21:07
kantai
kantai previously approved these changes Oct 11, 2024
jcnelson
jcnelson previously approved these changes Oct 11, 2024
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, but please test this (or add tests) before merging to confirm that once the PeerDB is connected, the LocalPeer you load out of it has a network_id equal to chain_id.

@obycode
Copy link
Contributor Author

obycode commented Oct 11, 2024

Approving, but please test this (or add tests) before merging to confirm that once the PeerDB is connected, the LocalPeer you load out of it has a network_id equal to chain_id.

Are there any existing tests that might be a good setup for this that you could point me to?

@kantai
Copy link
Member

kantai commented Oct 11, 2024

Are there any existing tests that might be a good setup for this that you could point me to?

You could add an assertion to any of the neon or nakamoto integration tests by querying /v2/info

@obycode obycode dismissed stale reviews from jcnelson and kantai via 3b5101f October 11, 2024 12:27
@obycode
Copy link
Contributor Author

obycode commented Oct 11, 2024

You could add an assertion to any of the neon or nakamoto integration tests by querying /v2/info

Cool, I was thinking about adding an integration test with this any way.

jcnelson
jcnelson previously approved these changes Oct 11, 2024
@obycode obycode requested a review from jcnelson October 11, 2024 19:04
Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending CI

@jferrant jferrant added this pull request to the merge queue Oct 14, 2024
Merged via the queue into develop with commit f427505 Oct 14, 2024
138 checks passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants