Fix/nakamoto downloader at reward cycle boundary #5305
Merged
+13
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the reward set to use to validate blocks (instead of the mod 1 indexing)
CharlieC3
previously approved these changes
Oct 11, 2024
jferrant
previously approved these changes
Oct 11, 2024
|
Not gonna lie...seeing the failures on this PR make me want to cry because I have seen those errors before and was 90% sure i fixed them...back to the drawing board. The prometheus metrics seem to not be updating when tests expect them to be and I thought the wait for would fix it but it doesn't seem to. |
obycode
approved these changes
Oct 11, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an off-by-one bug in which we load the wrong reward set to validate the tenure-end block of the last tenure of a reward set.