Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI fix: Fix occasional port bind error happening in mock mining #5311

Merged
merged 4 commits into from
Oct 14, 2024

Conversation

jferrant
Copy link
Collaborator

Check if in feature == testing and reserve test observer port in USED_PORTS

…f in feature == testing and reserving test observer port

Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant jferrant requested a review from a team as a code owner October 14, 2024 15:49
hstove
hstove previously approved these changes Oct 14, 2024
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smart catch! LGTM

@jferrant jferrant requested a review from obycode October 14, 2024 16:26
Signed-off-by: Jacinta Ferrant <[email protected]>
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jferrant jferrant added this pull request to the merge queue Oct 14, 2024
Merged via the queue into develop with commit bd39374 Oct 14, 2024
128 checks passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants