Feat: block info handling in Clarity 2 contracts post-3.0 #5321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s executing post-3.0
* add support to TestPeer for changing network_id/chain_id * test get-block-info? behavior in Clarity1 with primary testnet chain id and a different chain id
jcnelson
reviewed
Oct 17, 2024
jcnelson
reviewed
Oct 17, 2024
jcnelson
reviewed
Oct 17, 2024
jcnelson
reviewed
Oct 17, 2024
jcnelson
reviewed
Oct 17, 2024
jcnelson
approved these changes
Oct 17, 2024
|
LGTM, just please address my remaining comments |
obycode
approved these changes
Oct 17, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes get-block-info interpret block heights as tenure heights in Clarity 2 contracts.