-
Notifications
You must be signed in to change notification settings - Fork 668
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple_miners_with_custom_chain_id test to test chain id in a signer integration test #5322
Add multiple_miners_with_custom_chain_id test to test chain id in a signer integration test #5322
Conversation
… signer in an integration test Signed-off-by: Jacinta Ferrant <[email protected]>
0 test failures??? 🫢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Jacinta Ferrant <[email protected]>
… into chore/add-multiple-miners-with-custom-chain-id-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This was requested by Brice in #5314 (review)