Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple_miners_with_custom_chain_id test to test chain id in a signer integration test #5322

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

jferrant
Copy link
Collaborator

This was requested by Brice in #5314 (review)

… signer in an integration test

Signed-off-by: Jacinta Ferrant <[email protected]>
@wileyj
Copy link
Contributor

wileyj commented Oct 16, 2024

0 test failures??? 🫢

wileyj
wileyj previously approved these changes Oct 16, 2024
Copy link
Contributor

@wileyj wileyj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

hstove
hstove previously approved these changes Oct 16, 2024
Copy link
Contributor

@hstove hstove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

testnet/stacks-node/src/tests/signer/v0.rs Outdated Show resolved Hide resolved
@jferrant jferrant dismissed stale reviews from hstove and wileyj via 60ed0cf October 17, 2024 17:00
wileyj
wileyj previously approved these changes Oct 17, 2024
… into chore/add-multiple-miners-with-custom-chain-id-test
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jferrant jferrant added this pull request to the merge queue Oct 17, 2024
Merged via the queue into develop with commit faa9678 Oct 17, 2024
140 checks passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants