Improvements to event dispatcher retry logic #5327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could be helpful to debug issues communicating with API.
- Create the request outside the loop - Cap the backoff timeout at 3x timeout - Print the retry attempt and backoff time in the log - Add a jitter to the backoff time
obycode
force-pushed
the
chore/event-dispatcher-logs
branch
from
3b3e08e
to
1c595ad
Compare
jferrant
previously approved these changes
Oct 17, 2024
This avoids a clone in the happy case (where no retry is needed).
jferrant
approved these changes
Oct 18, 2024
kantai
approved these changes
Oct 18, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While debugging an issue with stacks-node -> API communication, I realized we could do some things better in this retry code. They are all pretty minor changes.