Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have get nakamoto headers return only the unique block ids and increase reward cycle length #5353

Merged
merged 5 commits into from
Oct 23, 2024

Conversation

jferrant
Copy link
Collaborator

Use a hashset when retrieving blocks from the test observer so we don't count duplicate blocks.
Increase the reward cycle length and max nakamoto tenures to increase the likelihood of hitting the test condition before the test ends.

@jferrant jferrant requested a review from a team as a code owner October 22, 2024 15:24
Signed-off-by: Jacinta Ferrant <[email protected]>
Signed-off-by: Jacinta Ferrant <[email protected]>
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@obycode obycode requested a review from a team October 22, 2024 18:01
@jferrant jferrant added this pull request to the merge queue Oct 23, 2024
@jferrant jferrant removed this pull request from the merge queue due to a manual request Oct 23, 2024
@jferrant jferrant added this pull request to the merge queue Oct 23, 2024
Merged via the queue into develop with commit bc7fe9e Oct 23, 2024
137 of 140 checks passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants