Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow pretty print logging in tests #5354

Merged
merged 5 commits into from
Nov 1, 2024
Merged

feat: allow pretty print logging in tests #5354

merged 5 commits into from
Nov 1, 2024
+8 −13

Conversation

hstove
Copy link
Contributor

@hstove hstove commented Oct 22, 2024

This allows STACKS_LOG_PP=1 to be used in tests.

We previously had two make_logger functions - one for tests and one for not tests. The only differences were:

  • The tests logger didn't allow pretty printing
  • The tests logger uses slog_term::TestStdoutWriter

This PR makes it so that we only have one make_logger function. Inside of that function, I've added a flag to use TestStdoutWriter in tests.

@hstove hstove requested a review from a team as a code owner October 22, 2024 17:30
@hstove hstove requested a review from obycode October 24, 2024 14:31
@hstove hstove requested a review from jferrant October 29, 2024 17:39
@hstove hstove added this pull request to the merge queue Nov 1, 2024
Merged via the queue into develop with commit 0c99ec7 Nov 1, 2024
137 of 140 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obycode obycode obycode approved these changes

@jferrant jferrant jferrant approved these changes

@jcnelson jcnelson Awaiting requested review from jcnelson

@kantai kantai Awaiting requested review from kantai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hstove @jcnelson @obycode @jferrant