Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Signer networking setup docs link #5363

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

aldur
Copy link
Contributor

@aldur aldur commented Oct 23, 2024

Description

Found and fixed a stale link.

I am afraid this might break again though. To improve, we could:

  1. Have a "well-known" doc URI that we ensure never changes. It can redirect the user to the most appropriate place.
  2. Show the warning only if the signer is not bound to a loopback address (core already has code to check that that could be used as inspiration).

@aldur aldur requested review from a team as code owners October 23, 2024 08:10
@aldur aldur changed the base branch from master to develop October 23, 2024 08:11
@aldur
Copy link
Contributor Author

aldur commented Oct 23, 2024

Tentatively basing this against develop, let me know if you'd like it to go somewhere else.

@kantai kantai added this pull request to the merge queue Oct 23, 2024
Merged via the queue into develop with commit b39904a Oct 23, 2024
136 of 140 checks passed
@blockstack-devops
Copy link
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@stacks-network stacks-network locked as resolved and limited conversation to collaborators Oct 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants