Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: event emitter will now emit new_txid in-case a tx replaces another #5381

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

usagi32
Copy link

@usagi32 usagi32 commented Oct 24, 2024

This extra information is required by an issue in the blockchain-api here and here.

Event emitter will now give to the api node which transaction replaced another.

@usagi32 usagi32 requested a review from a team as a code owner October 24, 2024 19:24
@CLAassistant
Copy link

CLAassistant commented Oct 24, 2024

CLA assistant check
All committers have signed the CLA.

jferrant
jferrant previously approved these changes Oct 24, 2024
@jferrant jferrant self-requested a review October 24, 2024 19:44
@jferrant
Copy link
Collaborator

I could be wrong, but I think this may need to be opened against develop, not master.

@usagi32
Copy link
Author

usagi32 commented Oct 24, 2024

@jferrant yes didn't know it existed.

@usagi32 usagi32 changed the base branch from master to develop October 24, 2024 19:58
@usagi32 usagi32 dismissed jferrant’s stale review October 24, 2024 19:58

The base branch was changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants