test: additional scenarios for empty sortition tenure extends #5415
+339
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcnelson
reviewed
Nov 1, 2024
| .build_next_block(2); | ||
|
|
||
| // Sleep to ensure the signers see both burn blocks | ||
| sleep_ms(5_000); |
There was a problem hiding this comment.
Can you use wait_for() here, and poll /v2/info?
There was a problem hiding this comment.
Yes, I can do that, but I think there should still be some additional sleep after /v2/info shows these blocks, since we want to ensure that the signer has processed the new burn blocks.
jcnelson
reviewed
Nov 1, 2024
jcnelson
reviewed
Nov 1, 2024
jcnelson
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see #5411 is also trying to test something similar. I will take a look to see if we are overlapping. I was also not able to reproduce any incorrect behavior here yet.