Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clippy in stacks node #5418

Merged
merged 1 commit into from
Nov 4, 2024
Merged

Fix clippy in stacks node #5418

merged 1 commit into from
Nov 4, 2024

Conversation

jferrant
Copy link
Collaborator

@jferrant jferrant commented Nov 2, 2024

No description provided.

Signed-off-by: Jacinta Ferrant <[email protected]>
@jferrant jferrant requested a review from a team as a code owner November 2, 2024 21:34
Copy link
Contributor

@obycode obycode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks! Just noticed two items that were ignored but could be fixed.

Copy link
Member

@jcnelson jcnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we make a clippy CI test alongside the rustfmt test?

@obycode
Copy link
Contributor

obycode commented Nov 4, 2024

Let's go ahead and merge this before it conflicts with something. We can address my comments in a separate PR.

@obycode obycode added this pull request to the merge queue Nov 4, 2024
Merged via the queue into develop with commit c6528b8 Nov 4, 2024
142 of 143 checks passed
obycode added a commit that referenced this pull request Nov 4, 2024
Additional minor change I noticed when reviewing #5418.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants