Add timestamp calculation to all block responses #5470
Conversation
Signed-off-by: Jacinta Ferrant <[email protected]>
|
|
||
| sortition_state | ||
| .cur_sortition | ||
| .burn_header_timestamp |
There was a problem hiding this comment.
This won't work i don't think...cause the burn header timestamp could be super duper old. Like this could be the second, third,...,Nth tenure extend. I will need to track the current tenure timestamp start better I think/Needs to reset per tenure extend.
There was a problem hiding this comment.
We can relatively easily check if a block has a TenureChange payload in it (doesn't matter if it's for an extend or new block), and then use that as our "start" for the timer
| @@ -190,6 +193,7 @@ impl BlockInfo { | |||
| } else { | |||
| self.signed_self.get_or_insert(get_epoch_time_secs()); | |||
| } | |||
| self.processed_time = Some(get_epoch_time_secs()); | |||
There was a problem hiding this comment.
This needs to be updated to use the block validate response process time (which will most likely be a nmb secs rather than a timestamp)
There was a problem hiding this comment.
I'm adding that now. I'm going to include a u128, validation_time_ms, in an Ok response.
pub struct BlockValidateOk {
pub signer_signature_hash: Sha512Trunc256Sum,
pub cost: ExecutionCost,
pub size: u64,
pub validation_time_ms: u128,
}Will open a PR after updating the tests.
| @@ -135,6 +136,8 @@ pub struct SignerConfig { | |||
| pub tenure_last_block_proposal_timeout: Duration, | |||
| /// How much time to wait for a block proposal validation response before marking the block invalid | |||
| pub block_proposal_validation_timeout: Duration, | |||
| /// How much idle tie must pass before allowing a tenure extend | |||
There was a problem hiding this comment.
| /// How much idle tie must pass before allowing a tenure extend | |
| /// How much idle time must pass before allowing a tenure extend |
| @@ -190,6 +193,7 @@ impl BlockInfo { | |||
| } else { | |||
| self.signed_self.get_or_insert(get_epoch_time_secs()); | |||
| } | |||
| self.processed_time = Some(get_epoch_time_secs()); | |||
There was a problem hiding this comment.
I'm adding that now. I'm going to include a u128, validation_time_ms, in an Ok response.
pub struct BlockValidateOk {
pub signer_signature_hash: Sha512Trunc256Sum,
pub cost: ExecutionCost,
pub size: u64,
pub validation_time_ms: u128,
}Will open a PR after updating the tests.
| @@ -190,6 +193,7 @@ impl BlockInfo { | |||
| } else { | |||
| self.signed_self.get_or_insert(get_epoch_time_secs()); | |||
| } | |||
| self.processed_time = Some(get_epoch_time_secs()); | |||
First pass. Haven't tested this at all and this was just first thoughts.