Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sbtc_signer.md #486

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Update sbtc_signer.md #486

merged 2 commits into from
Jul 31, 2023

Conversation

andrerserrano
Copy link
Contributor

@andrerserrano andrerserrano commented Jul 28, 2023 •
edited
Loading

Updating documentation for the sBTC signer

@CLAassistant
Copy link

CLAassistant commented Jul 28, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

wileyj
wileyj reviewed Jul 28, 2023
View reviewed changes
sBTC/sbtc_signer.md Outdated Show resolved Hide resolved
@wileyj
Copy link
Contributor

wileyj commented Jul 28, 2023

overall, changes look good.
some additional formatting would be welcome, but that can be addressed later.

one potential change to some verbiage (not a blocker though), but otherwise it looks good

@andrerserrano
Update sbtc_signer.md
71579e8 
Revised language
@andrerserrano andrerserrano merged commit 302508e into stacks-network:master Jul 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wileyj wileyj wileyj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrerserrano @CLAassistant @wileyj