Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding testing standards doc #515

Merged
merged 2 commits into from
Nov 13, 2023
Merged

adding testing standards doc #515

merged 2 commits into from
Nov 13, 2023

Conversation

wileyj
Copy link
Contributor

@wileyj wileyj commented Oct 13, 2023

Porting @AshtonStephens testing standards doc from a google doc to markdown.

@wileyj wileyj self-assigned this Oct 13, 2023
will-corcoran
will-corcoran approved these changes Oct 14, 2023
View reviewed changes
Copy link

@will-corcoran will-corcoran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

AshtonStephens
AshtonStephens requested changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@AshtonStephens AshtonStephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! Wow the diagrams look gread! Exceot the TODOS in the appendix should have been deleted - that's my bad.

@wileyj
Copy link
Contributor Author

wileyj commented Oct 17, 2023

for future reference, i used this app to recreate the diagrams in @AshtonStephens doc: https://app.diagrams.net/

and exported as a PNG with transparent background.

kenrogers
kenrogers approved these changes Nov 12, 2023
View reviewed changes
Copy link
Contributor

@kenrogers kenrogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wileyj wileyj merged commit ae3d301 into master Nov 13, 2023
1 check passed
@wileyj wileyj deleted the feat/standards branch November 13, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenrogers kenrogers kenrogers approved these changes

@AshtonStephens AshtonStephens AshtonStephens approved these changes

@will-corcoran will-corcoran will-corcoran approved these changes

Assignees

@wileyj wileyj

Labels
Content File
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wileyj @kenrogers @AshtonStephens @will-corcoran