-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SIP-024 Emergency Fix to Data Validation and Serialization Behavior #141
Conversation
pending the branch addition, looks good! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approval is the official sign off from the Technical CAB.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approval is the official sign off from the Governance CAB.
(list (tuple (a 1)) (tuple (b 1) (a 1))) | ||
``` | ||
|
||
The Clarity runtime will treat each item of this list as if it only |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@obycode does clarity vm expects type of each item to match the type of "first element" from the list ? It is not clear from the example if the type should be intersection set of all keys or match the first element's keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was treating all of the elements as the "least common super-type", so an intersection of all keys as you said.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correction, my previous comment is wrong -- the ordering did matter, so it was based on the type of the first element. Later elements could have more fields, but not less.
SIP Editor Update 6/30/2023: Status: Approved Full details on this SIP can be seen in detail on the SIP impact assessment sheet where RICE scoring was conducted and tracked. Additional comments also available here: |
Draft PR for SIP 024.
This is an emergency SIP that discusses a resolution to a bug in the Clarity type system. The changes in this SIP will ideally roll out along with the changes discussed in SIP 022.