-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enforce no spaces before closing brackets #38
Enforce no spaces before closing brackets #38
Conversation
Also add test cases
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat 👍
This will be part of standard v14 |
@feross Does this mean further pull requests should be opened in https://github.com/standard/standard instead? |
@tewsonseeoun-toast For This makes it much easier to do a beta release of I kept this PR open so I can merge it when it's time :) But in the future, I would direct PRs to the main |
@feross That's fair enough. Thank you for the explanation! |
Fixes standard/standard#1348.
Enforce no spaces before closing brackets and also add test cases.
There's some duplicate code around setting up
eslint.CLIEngine
in the tests which I hope to improve in a separate PR so this PR is focused only on the linked issue above.