Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filtering by subject and level for MATHScenario #1137

Merged
merged 3 commits into from
Nov 23, 2022
Merged

Fix filtering by subject and level for MATHScenario #1137

merged 3 commits into from
Nov 23, 2022

Conversation

teetone
Copy link
Member

@teetone teetone commented Nov 15, 2022

No description provided.

@teetone
Copy link
Member Author

teetone commented Nov 15, 2022

TODO: merge after release

@teetone teetone mentioned this pull request Nov 15, 2022
Merged
friedeggs
friedeggs approved these changes Nov 15, 2022
View reviewed changes
Copy link
Contributor

@friedeggs friedeggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not managed to test locally (missing credentials just to dry run?) but the code changes LGTM.

@teetone teetone merged commit caecfdb into main Nov 23, 2022
@teetone teetone deleted the mathfix branch November 23, 2022 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@friedeggs friedeggs friedeggs approved these changes

Assignees
No one assigned
Labels
reasoning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teetone @friedeggs