Add openai/gpt-3.5-turbo-0301 model #1401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @JoelNiklaus |
|
@teetone could you take a look? Multiple people are asking for this and it would be good to get this out soon. Thanks! |
teetone
approved these changes
Mar 25, 2023
| "n": request.num_completions, | ||
| # TODO: Setting stop causes the server to return a HTTP 500 error. | ||
| # "stop": request.stop_sequences or None, # API doesn't like empty list | ||
| "max_tokens": request.max_tokens + 1, # Uhhh |
There was a problem hiding this comment.
Removing the +1 for now.
The special roles take up tokens, so if you want 1 token, you actually have to ask 2 tokens. But I'd rather handle this elsewhere.
| @@ -79,6 +79,7 @@ def get_client(self, request: Request) -> Client: | |||
| client = OpenAIClient( | |||
| api_key=self.credentials["openaiApiKey"], | |||
| cache_config=cache_config, | |||
| tokenizer_client=self.get_tokenizer_client("huggingface"), | |||
| chat_gpt_client=chat_gpt_client, | |||
There was a problem hiding this comment.
Do you mind removing chat_gpt_client and deleting ChatGPTClient? I don't think we need it now.
There was a problem hiding this comment.
OK, will do this in a new PR.
There was a problem hiding this comment.
Filed #1447 to track removing ChatGPTClient.
Add window service Comments Fixes More fixes Review fixes
yifanmai
force-pushed
the
yifanmai/1218-chatgpt
branch
from
48d91a9
to
4113d59
Compare
yifanmai
changed the title
yifanmai
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1218