Support emoji for MTurk import / export #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated layout:
|
|
@YianZhang This is ready for review; please take a look. |
percyliang
reviewed
Aug 8, 2023
| characters, e.g. 😀, and replaces each 4-byte character with an | ||
| HTML span with the 4 bytes encoded as a JSON array, e.g.: | ||
|
|
||
| <span class='emoji-bytes' data-emoji-bytes='[240, 159, 152, 128]'></span> |
percyliang
approved these changes
Aug 8, 2023
|
Actually, I have no idea why I didn't think of HTML entity escaping... it should work. I'll try it out. |
|
It works! I swapped to using HTML entities. Can't believe I didn't think about that. |
percyliang
reviewed
Aug 11, 2023
|
|
||
|
|
||
| # Source: https://github.com/charman/mturk-emoji | ||
| def replace_emoji_characters(s): |
percyliang
reviewed
Aug 11, 2023
Comment on lines
10
to
14
| This function takes a Unicode string containing 4-byte Unicode | ||
| characters, e.g. 😀, and replaces each 4-byte character with an | ||
| HTML span with the 4 bytes encoded as a JSON array, e.g.: | ||
|
|
||
| <span class='emoji-bytes' data-emoji-bytes='[240, 159, 152, 128]'></span> |
There was a problem hiding this comment.
This is out of date, right?
percyliang
reviewed
Aug 11, 2023
| s (Unicode string): | ||
| Returns: | ||
| Unicode string with all 4-byte Unicode characters in the source | ||
| string replaced with HTML spans |
danielz02
pushed a commit
to danielz02/helm
that referenced
this pull request
Sep 7, 2023
danielz02
pushed a commit
to danielz02/helm
that referenced
this pull request
Sep 7, 2023
danielz02
pushed a commit
to danielz02/helm
that referenced
this pull request
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Escapes emoji for Mechanical Turk exporting and importing because Mechanical Turk does not support unescaped emoji. (Error message: "Unsupported characters found")
Also updates the layout to improve whitespace formatting.