Remove stats with NaN values #1784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
percyliang
approved these changes
Aug 15, 2023
percyliang
reviewed
Aug 15, 2023
src/helm/benchmark/metrics/metric.py
Outdated
| @@ -88,6 +89,19 @@ def process(self, request_state_set: RequestStateSet) -> List[Stat]: | |||
| ) | |||
| ) | |||
|
|
|||
| # Drop any instance stats that contain NaN, because Python's stdlib json.dumps() | |||
There was a problem hiding this comment.
Only question is whether this is the right place to put it. I think maybe we should at least make this a helper function?
There was a problem hiding this comment.
Seems like it could be better to put it closer to the point of serialization?
There was a problem hiding this comment.
We should make it clear that upstream computation should not produce NaNs, and this is just a bandaid safety check? (In which case, we should fix things upstream.)
There was a problem hiding this comment.
OK, I moved it to the point of serialization. I'll do the upstream fix in a different PR.
danielz02
pushed a commit
to danielz02/helm
that referenced
this pull request
Sep 7, 2023
danielz02
pushed a commit
to danielz02/helm
that referenced
this pull request
Sep 7, 2023
danielz02
pushed a commit
to danielz02/helm
that referenced
this pull request
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drop any instance stats that contain
NaN, because Python's stdlibjson.dumps()will produce invalid JSON when serializing aNaN.See:
Addresses #1765