Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tokio to 1.39.2 #4180

Open
wants to merge 1 commit into
base: dag-master
Choose a base branch
from
Open

Upgrade tokio to 1.39.2 #4180

wants to merge 1 commit into from

Conversation

sanlee42
Copy link
Member

@sanlee42 sanlee42 commented Aug 9, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Other information

Summary by CodeRabbit

  • New Features

    • Upgraded the Tokio dependency to version 1.39, enabling access to enhanced features and improvements for better performance and functionality.
  • Bug Fixes

    • Resolved potential compatibility issues with the previous version of Tokio.

@sanlee42 sanlee42 requested a review from nkysg August 9, 2024 03:16
Copy link

coderabbitai bot commented Aug 9, 2024

Walkthrough

The update to the Cargo.toml file focuses on enhancing the project's integration with the Tokio asynchronous runtime by upgrading the Tokio dependency from version 1 to 1.39. This modification allows developers to leverage new features and improvements available in the more recent version, while all other dependencies remain unchanged.

Changes

File Change Summary
Cargo.toml Updated tokio version from ^1 to ^1.39 to utilize new features and improvements.

Poem

🐰 In the code where bunnies hop,
A version change makes functions pop!
With Tokio's grace, we’ll leap so high,
New features gleam like stars in the sky.
Let’s code and play, with joy we sing,
Upgrading dependencies is a wondrous thing! 🌟


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 00a37d8 and 783ba5a.

Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
Files selected for processing (1)
  • Cargo.toml (1 hunks)
Additional comments not posted (1)
Cargo.toml (1)

527-527: Verify compatibility with Tokio 1.39.

The tokio dependency has been updated to version ^1.39. Ensure that all usages of tokio in the codebase are compatible with this new version, as it may introduce changes that affect existing code.

Copy link

github-actions bot commented Aug 9, 2024

Benchmark for 13075bc

Click to view benchmark
Test Base PR %
accumulator_append 816.8±147.99µs 722.3±36.43µs -11.57%
block_apply/block_apply_10 364.0±4.64ms 364.1±4.83ms +0.03%
block_apply/block_apply_1000 38.2±0.67s 37.8±0.79s -1.05%
get_with_proof/db_store 44.7±1.67µs 44.6±0.89µs -0.22%
get_with_proof/mem_store 36.6±2.45µs 36.6±0.66µs 0.00%
put_and_commit/db_store/1 116.0±11.33µs 115.7±7.10µs -0.26%
put_and_commit/db_store/10 1053.0±39.53µs 1041.4±77.80µs -1.10%
put_and_commit/db_store/100 9.7±0.32ms 9.2±0.36ms -5.15%
put_and_commit/db_store/5 535.1±30.30µs 541.7±39.87µs +1.23%
put_and_commit/db_store/50 5.2±0.64ms 4.7±0.16ms -9.62%
put_and_commit/mem_store/1 72.2±8.53µs 74.3±11.59µs +2.91%
put_and_commit/mem_store/10 683.7±83.51µs 704.1±111.85µs +2.98%
put_and_commit/mem_store/100 6.6±0.47ms 6.6±0.48ms 0.00%
put_and_commit/mem_store/5 343.2±50.19µs 334.0±28.78µs -2.68%
put_and_commit/mem_store/50 3.4±0.48ms 3.2±0.26ms -5.88%
query_block/query_block_in(10)_times(100) 4.6±0.23ms 4.4±0.14ms -4.35%
query_block/query_block_in(10)_times(1000) 47.7±7.68ms 44.8±1.20ms -6.08%
query_block/query_block_in(10)_times(10000) 449.8±8.75ms 452.2±10.45ms +0.53%
query_block/query_block_in(1000)_times(100) 1155.1±27.19µs 1091.3±11.11µs -5.52%
query_block/query_block_in(1000)_times(1000) 11.5±0.32ms 13.1±3.53ms +13.91%
query_block/query_block_in(1000)_times(10000) 115.8±3.60ms 111.7±2.00ms -3.54%
storage_transaction 1169.7±475.43µs 1086.0±428.26µs -7.16%
vm/transaction_execution/1 456.2±31.47ms 410.2±14.63ms -10.08%
vm/transaction_execution/10 146.0±12.57ms 129.5±3.54ms -11.30%
vm/transaction_execution/20 124.4±11.47ms 125.1±7.88ms +0.56%
vm/transaction_execution/5 184.6±19.61ms 159.2±8.67ms -13.76%
vm/transaction_execution/50 144.9±7.09ms 144.1±10.73ms -0.55%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants