Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update serialization-of-cairo-types.adoc to correctly serialize u256 inside a struct #1341

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Kelvyne
Copy link

@Kelvyne Kelvyne commented Aug 28, 2024

Fix mistake in serialization of U256 inside of a struct U256 are serialized as [low_128, high_128] as per the same documentation.

Description of the Changes

Please add a detailed description of the change, whether it's an enhancement or a bugfix.
If the PR is related to an open issue please link to it.

PR Preview URL

After you push a commit to this PR, a preview is built and a URL to the root of the preview appears in the comment feed.

Paste here the specific URL(s) of the content that this PR addresses.

Check List

  • Changes have been done against main branch, and PR does not conflict
  • PR title follows the convention: <docs/feat/fix/chore>(optional scope): <description>, e.g: fix: minor typos in code

This change is Reviewable

Fix mistake in serialization of U256 inside of a struct
U256 are serialized as [low_128, high_128] as per the same documentation.
@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1341/ .

@Kelvyne Kelvyne changed the title Update serialization-of-cairo-types.adoc fix: update serialization-of-cairo-types.adoc to correctly serialize u256 inside a struct Aug 29, 2024
@starknet-bot
Copy link
Collaborator

Your preview build is ready! ✨ Check the following link in 1-2 minutes: https://starknet-io.github.io/starknet-docs/pr-1341/ .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants