xpath, improvement: add another xpath for image for Hustler #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've tweaked the xpath selectors for Title, Date, Performers, and Details
I think older scenes with descriptions must have something about the pages that means Details can't be scraped in the same way. In any case, the images work and I've now fixed all of the issues for new scenes and all but one (Details) of the issues for older scenes. |
JackDawson94
approved these changes
Jun 30, 2023
MrX292
reviewed
Jul 3, 2023
| postProcess: | ||
| - parseDate: Jan 02, 2006 | ||
| Details: //meta[@property="og:description"]/@content|//div[@class="description"]/p | ||
| Image: //div[@class="img-container"]/img/@src | ||
| Details: //p[following-sibling::a[@class="clickable"]]|//meta[@property="og:description"]/@content|//div[@class="description"]/p |
There was a problem hiding this comment.
Suggested change
| Details: //p[following-sibling::a[@class="clickable"]]|//meta[@property="og:description"]/@content|//div[@class="description"]/p | |
| Details: //div[@class="panel-content"]/div/div/text()|//meta[@property="og:description"]/@content|//div[@class="description"]/p |
gets part of the details for older scenes
There was a problem hiding this comment.
hmm, when I try this with the new scenes, it also gets the first part (before clicking Read More) rather than the full description... will see if I can come up with a selector combo that gets the full description for all scenes
litcum22
pushed a commit
to litcum22/CommunityScrapers
that referenced
this pull request
Aug 1, 2023
xpath, improvement: add another xpath for image for Hustler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds another xpath selector for the existing Hustler.yaml scraper so that it can get the cover image for scene pages, e.g.
I left the existing selector in case there are different styles/layouts for scene pages where the existing selector will continue to work.