add native beforeUnload handlers #730
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
will rebase |
feederbox826
force-pushed
the
before-unload
branch
from
66caa89
to
284dcf9
Compare
feederbox826
force-pushed
the
before-unload
branch
from
284dcf9
to
84ddf73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially addresses #594
doesn't work with SPA navigation because
it's "unstable", reactrouter does not intercept it, it does not work on SPAs, the PR (s) are dead, is still unstable
If someone else who is more versed and has more patience for SPAs and React wants to improve, it they are more than welcome to. In the meantime I will just intercept navigate events