WIP: Autotag Improvements #1927
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -12,6 +12,8 @@ type Tag { | |||
| gallery_count: Int # Resolver | |||
| performer_count: Int | |||
|
|
|||
| allow_autotag: Int | |||
There was a problem hiding this comment.
Naive question: why the Int and not Bool ? Probably requires a comment what it encodes in the GraphQL schema.
I know the database doesn't support bools directly, but chances are the sql.NullBool or a straight bool will work at that level too because of the way Scanner/Valuer works. In any case, I don't think we should let the database schema bleed through to the GraphQL layer.
| Name string `db:"name" json:"name"` // TODO make schema not null | ||
| CreatedAt SQLiteTimestamp `db:"created_at" json:"created_at"` | ||
| UpdatedAt SQLiteTimestamp `db:"updated_at" json:"updated_at"` | ||
| AllowAutotag int `db:"allow_autotag" json:"allow_autotag"` |
There was a problem hiding this comment.
Try using a bool here. I think it encodes it to 0/1.
| @@ -443,14 +444,13 @@ func performerStudiosCriterionHandler(qb *performerQueryBuilder, studios *models | |||
| if studios != nil { | |||
| var clauseCondition string | |||
|
|
|||
| switch studios.Modifier { | |||
| case models.CriterionModifierIncludes: | |||
| if studios.Modifier == models.CriterionModifierIncludes { | |||
There was a problem hiding this comment.
The gocritic linter is likely to ask for a switch here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, it probably doesn't even build yet.
Final goal is to have:
Current time to beat is about 2 weeks to autotag images on my instance.