Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional performer urls #1959

Closed
wants to merge 3 commits into from
Closed

Conversation

7dJx1qP
Copy link
Contributor

@7dJx1qP 7dJx1qP commented Nov 5, 2021

Basic support for additional performer urls, partial solution to #1868. Adds a performers_urls table (performer_id, url). It doesn't replace the performer url field and I haven't made an attempt to integrate the additional urls with any other features like scraping or filtering. For now it's just a simple way to store additional performer urls.

Edit tab
image

Details tab
image

@7dJx1qP 7dJx1qP marked this pull request as ready for review November 5, 2021 02:46
@7dJx1qP
Copy link
Contributor Author

7dJx1qP commented Nov 6, 2021

Refactored the input based on the stash-box integration input but with a scrape button added in. This removes the need for an edit button, because the urls are edited in place.
image

@kermieisinthehouse kermieisinthehouse added the feature Pull requests that add a new feature label Nov 6, 2021
@kermieisinthehouse kermieisinthehouse added this to the Version 0.12.0 milestone Nov 6, 2021
@WithoutPants
Copy link
Collaborator

I couldn't find where this was documented, but the intent was to generalise our existing URL fields into a type/url table.

That is, where we currently have URL, Twitter, Instagram, we would instead have three URL entries in the table: one for website, one for twitter and one for instagram. The UI would be a pair of text fields. We could then use the entries to populate the top links bar by looking for hard-coded strings.

@reapier
Copy link

reapier commented Sep 27, 2023

@7dJx1qP Any reason why this PR was closed? Mind if if open a similar PR to try to get this in?

@reapier
Copy link

reapier commented Sep 28, 2023

@WithoutPants should this PR be update to match this change: https://github.com/stashapp/stash/pull/3852/commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants