Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix previews generation bug #231

Merged
merged 1 commit into from
Nov 30, 2019
Merged

Conversation

bnkai
Copy link
Collaborator

@bnkai bnkai commented Nov 28, 2019

During the preview generation task on some files (very small percentage) the process seemed to take too much time to complete.
Upon investigation it seems that the trimmed files to be concatenated had weird durations / timings and so the resulting mp4 file generated had also weird fps (0.001) making the generate task stuck to a single scene for hours.
Simply changing the order of the ffmpeg -t parameter after the input -i fixes all weird occurences and goes past the problematic files as it should.
I couldn't find anything in common for the files affected (original,reencodes,mp4,webm ) , i could only verify through discord that the specific change is indeed generating correct previews with the problematic media files.

@bnkai bnkai added the bug Something isn't working label Nov 28, 2019
@StashAppDev
Copy link
Member

Hmm, interesting. According to this it seems like only the location of the ss flag would affect the processing, I can't find any info on the t flag. No big deal though, I'll go ahead and merge.

@StashAppDev StashAppDev merged commit 3f511e4 into stashapp:develop Nov 30, 2019
@WithoutPants WithoutPants mentioned this pull request Feb 4, 2020
10 tasks
@bnkai bnkai deleted the previews_bug branch June 12, 2020 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants