Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add O-counter #334

Merged
merged 4 commits into from
Feb 3, 2020
Merged

Add O-counter #334

merged 4 commits into from
Feb 3, 2020

Conversation

WithoutPants
Copy link
Collaborator

@WithoutPants WithoutPants commented Jan 25, 2020

Adds an "o-counter". This is represented as a 💦 looking icon. When the counter is > 0, then it is included in the scene card:

image

On the scene details page, I have implemented a button for the counter. My default, it shows the icon and counter value. When clicked, this button increments the counter. If the button is hovered for 1 second, and the counter value > 0, then a popover menu is shown with decrement and reset items:

image

I need advice as to where to put this button in the scene details page. Below is a screenshot of possible placements:

image

To me the best here is probably on the tabs line. We could also right-align it:

image

Another option is overlaying the button on the scene player when the player is moused-over:

image

The button is not shown in the fullscreen view.

Let me know where you'd like it placed.

TODO:

  • add filter for o-counter (<, >, !=, =)
  • add button functionality to the scene card (so that you can click the o-counter button from the scene query page)
  • add an operation on the scene query page to reset o-counter for selected scenes

@bnkai
Copy link
Collaborator

bnkai commented Jan 25, 2020

Imho the tabs right align one has a cleaner look.
right align

@bnkai bnkai added the feature Pull requests that add a new feature label Jan 27, 2020
@WithoutPants
Copy link
Collaborator Author

I've added a filter and I think I'll leave it there for now. Performing other functions on the query page requires more structural changes, so I'll leave it for a future iteration.

@WithoutPants WithoutPants changed the title [WIP][RFC] Add O-counter Add O-counter Jan 31, 2020
@WithoutPants
Copy link
Collaborator Author

Resolves #291

@bnkai
Copy link
Collaborator

bnkai commented Jan 31, 2020

Works ok.
Just a note for the filter. IS NULL or NOT NULL aren't usefull for the O-Counter since it's NOT NULL always (0 by default)

@Leopere Leopere merged commit f87117b into stashapp:develop Feb 3, 2020
@WithoutPants WithoutPants mentioned this pull request Feb 4, 2020
10 tasks
ghost pushed a commit to InfiniteStash/stash that referenced this pull request Feb 8, 2020
ghost pushed a commit to InfiniteStash/stash that referenced this pull request Mar 1, 2020
@WithoutPants WithoutPants deleted the splooge_counter branch May 15, 2020 07:13
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
* Add backend support for o-counter

* Add o-counter buttons everywhere

* Put o-counter button right-aligned on tabs

* Add o-counter filter
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull requests that add a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants