-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add O-counter #334
Merged
Merged
Add O-counter #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've added a filter and I think I'll leave it there for now. Performing other functions on the query page requires more structural changes, so I'll leave it for a future iteration. |
Resolves #291 |
Works ok. |
ghost
pushed a commit
to InfiniteStash/stash
that referenced
this pull request
Feb 8, 2020
ghost
pushed a commit
to InfiniteStash/stash
that referenced
this pull request
Mar 1, 2020
Tweeticoats
pushed a commit
to Tweeticoats/stash
that referenced
this pull request
Feb 1, 2021
* Add backend support for o-counter * Add o-counter buttons everywhere * Put o-counter button right-aligned on tabs * Add o-counter filter
Tweeticoats
pushed a commit
to Tweeticoats/stash
that referenced
this pull request
Feb 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an "o-counter". This is represented as a 💦 looking icon. When the counter is > 0, then it is included in the scene card:
On the scene details page, I have implemented a button for the counter. My default, it shows the icon and counter value. When clicked, this button increments the counter. If the button is hovered for 1 second, and the counter value > 0, then a popover menu is shown with decrement and reset items:
I need advice as to where to put this button in the scene details page. Below is a screenshot of possible placements:
To me the best here is probably on the tabs line. We could also right-align it:
Another option is overlaying the button on the scene player when the player is moused-over:
The button is not shown in the fullscreen view.
Let me know where you'd like it placed.
TODO: