Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to avoid creating generated folder inside data folder. #335

Merged
merged 2 commits into from
Feb 1, 2020

Conversation

thundergreen
Copy link
Contributor

This Fix is to avoid that generated folder will be created inside the movie /video files forder which leads to see the generated clips of the movies in SCENES.

This Fix is to avoid that ```generated``` folder will be created inside the movie /video files forder which leads to see the generated clips of the movies in SCENES.
@bnkai bnkai added the bug Something isn't working label Jan 27, 2020
@@ -20,12 +20,14 @@ services:
volumes:
- /etc/localtime:/etc/localtime:ro
## Keep configs here.
- ./config:/root/.stash
- /your/path/to/Stash/config:/root/.stash
Copy link
Collaborator

@bnkai bnkai Jan 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe
/path/to/your/stash/config
instead? same for the rest

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer the relative path personally. This way we don’t inadvertently start filling people’s host file system with junk.

@Leopere
Copy link
Collaborator

Leopere commented Jan 31, 2020

I’m not sure if some of the suggested edits are really a good way to go for resolving these issues unfortunately I don’t like assuming that we can expect that the end user is going to tweak the docker compose we ship before they turn it on for the first time and I don’t want to start littering in peoples file systems.

Added generated volume , removed transcoded as it wasn't needed.
All volumes remain with relative paths as suggested.
@bnkai
Copy link
Collaborator

bnkai commented Feb 1, 2020

As recommended by @Leopere edited back the volumes to be relative.
I also removed the transcodes volume as it wasn't used anyway. (We didn't set any env variable for it and it is created ok by default in the generated folder anyway)
Added an extra example comment to make it more clear how to change the paths.

Copy link
Collaborator

@Leopere Leopere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this I'm not certain if it'll hit some reading issues for some people but I think it's fine.

@Leopere Leopere merged commit 066295f into stashapp:develop Feb 1, 2020
Tweeticoats pushed a commit to Tweeticoats/stash that referenced this pull request Feb 1, 2021
)

* Fix to avoid creating generated folder inside data folder. 

This Fix is to avoid that ```generated``` folder will be created inside the movie /video files forder which leads to see the generated clips of the movies in SCENES.

* Update docker-compose.yml

Added generated volume , removed transcoded as it wasn't needed.
All volumes remain with relative paths as suggested.

Co-authored-by: bnkai <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants