-
-
Notifications
You must be signed in to change notification settings - Fork 783
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to avoid creating generated folder inside data folder. #335
Conversation
This Fix is to avoid that ```generated``` folder will be created inside the movie /video files forder which leads to see the generated clips of the movies in SCENES.
docker/production/docker-compose.yml
Outdated
@@ -20,12 +20,14 @@ services: | |||
volumes: | |||
- /etc/localtime:/etc/localtime:ro | |||
## Keep configs here. | |||
- ./config:/root/.stash | |||
- /your/path/to/Stash/config:/root/.stash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe
/path/to/your/stash/config
instead? same for the rest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer the relative path personally. This way we don’t inadvertently start filling people’s host file system with junk.
I’m not sure if some of the suggested edits are really a good way to go for resolving these issues unfortunately I don’t like assuming that we can expect that the end user is going to tweak the docker compose we ship before they turn it on for the first time and I don’t want to start littering in peoples file systems. |
Added generated volume , removed transcoded as it wasn't needed. All volumes remain with relative paths as suggested.
As recommended by @Leopere edited back the volumes to be relative. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this I'm not certain if it'll hit some reading issues for some people but I think it's fine.
) * Fix to avoid creating generated folder inside data folder. This Fix is to avoid that ```generated``` folder will be created inside the movie /video files forder which leads to see the generated clips of the movies in SCENES. * Update docker-compose.yml Added generated volume , removed transcoded as it wasn't needed. All volumes remain with relative paths as suggested. Co-authored-by: bnkai <[email protected]>
This Fix is to avoid that
generated
folder will be created inside the movie /video files forder which leads to see the generated clips of the movies in SCENES.