Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated graphql fields #4064

Merged
merged 14 commits into from
Oct 17, 2023

Conversation

WithoutPants
Copy link
Collaborator

Removes deprecated fields that have been deprecated for a long time. This potentially impacts plugins.

@WithoutPants WithoutPants added the chore Pull requests for refactoring and admin work label Aug 27, 2023
@WithoutPants WithoutPants added this to the Version 0.23.0 milestone Aug 27, 2023
@WithoutPants
Copy link
Collaborator Author

The following query resolvers are being removed:

  • listPerformerScrapers - Use listScrapers(types: [PERFORMER])
  • listSceneScrapers - Use listScrapers(types: [SCENE])
  • listGalleryScrapers - Use listScrapers(types: [GALLERY])
  • listMovieScrapers - Use listScrapers(types: [MOVIE])
  • scrapePerformerList - use scrapeSinglePerformer
  • scrapePerformer - use scrapeSinglePerformer
  • scrapeScene - use scrapeSingleScene
  • scrapeGallery - use scrapeSingleGallery
  • scrapeFreeonesPerformerList - use scrapeSinglePerformer with scraper_id = builtin_freeones

The following fields are being removed from ConfigGeneralInput and ConfigGeneralResult:

  • trustedProxies - no longer supported
  • scraperUserAgent - use field in ConfigScraping[Input/Result] instead
  • scraperCDPPath - use field in ConfigScraping[Input/Result] instead
  • scraperCertCheck - use field in ConfigScraping[Input/Result] instead

The following fields are being removed from ConfigInterfaceInput and ConfigInterfaceResult:

  • slideshowDelay - Use imageLightbox.slideshowDelay
  • disabledDropdownCreate - Use disableDropdownCreate

The following filter criteria are being removed from the applicable FilterType inputs:

  • height - Use height_cm instead
  • stash_id - Use stash_id_endpoint instead
  • rating - Use 1-100 range with rating100

SceneMarkerFilterType.tag_id is being removed in favour of tags.

The rating field is being removed from all applicable types, in favour of the rating100 field.

The checksum, path and file_mod_time fields are being removed Scene, Gallery and Image types. These can be accessed via the applicable files field (or visual_files in image). oshash and phash are also removed from Scene.

checksum is also removed from Movie, Performer and Studio types.

The following fields are being removed from Performer and applicable inputs (in addition to the changes above):

  • height - use height_cm instead
  • aliases - use alias_list instead

chapters_vtt is being removed from ScenePathsType.

Gallery.images is being removed. This can be accessed via findImages instead.

file is being removed from Scene and Image in favour of Files.

The useFileMetadata and stripFileExtension flags in ScanMetadata[Input/Options] are being removed. These were unused.

@WithoutPants WithoutPants merged commit b6714fa into stashapp:develop Oct 17, 2023
2 checks passed
halkeye pushed a commit to halkeye/stash that referenced this pull request Sep 1, 2024
* Remove deprecated list*Scrapers queries
* Remove other deprecated query resolvers
* Remove deprecated config fields
* Remove deprecated gallery fields
* Remove deprecated image fields
* Remove deprecated movie fields
* Remove deprecated performer fields
* Document scrape function issue
* Remove deprecated studio fields
* Remove deprecated scan input fields
* Remove deprecated scene fields
* Remove deprecated fields from filters
* Remove scene.file_mod_time
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for refactoring and admin work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant