Add disambiguation and links to tagger results #4180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feederbox826
added a commit
to feederbox826/CommunityScripts
that referenced
this pull request
Oct 25, 2023
resolved in stashapp/stash#4180
halkeye
pushed a commit
to halkeye/stash
that referenced
this pull request
Sep 1, 2024
Co-authored-by: WithoutPants <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the scene tagger results list, disambiguations are now shown beside a performers name. It's added to the Stashbox name, the matched local name and the local name currently selected in the dropdown.
This helps ensuring the matches are correct without having to go to the individual performer pages to confirm.
Those same performer names, as well as studio names are now links. Stashbox links open a new tab to the Stashbox they came from, and local names open a new tab to the local instance.
This removes the need for https://docs.stashapp.cc/add-ons/userscripts/#stash-scene-tagger-linkify (which no longer works correctly with the disambiguations added).