Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast improvements #4584

Merged
merged 6 commits into from
Feb 18, 2024
Merged

Toast improvements #4584

merged 6 commits into from
Feb 18, 2024

Conversation

WithoutPants
Copy link
Collaborator

Resolves #1323

Changes the toast placement from center top to top right:

image

The toast container is now animated to slide in and out from the right edge of the window.

On mobile viewports the toast is placed center bottom, and slides in from the left:

image

The error toast is changed to add a button and handle clicks to bring up a dialog. On https connections, the dialog gives the option to copy the error message to clipboard:

image
image

@WithoutPants WithoutPants added the improvement Something needed tweaking. label Feb 18, 2024
@WithoutPants WithoutPants added this to the Version 0.25.0 milestone Feb 18, 2024
@WithoutPants WithoutPants merged commit 6e9718a into stashapp:develop Feb 18, 2024
2 checks passed
@tonynca
Copy link

tonynca commented Feb 19, 2024

Awesome!

halkeye pushed a commit to halkeye/stash that referenced this pull request Sep 1, 2024
* Change default toast placement
* Position at bottom on mobile
* Show single toast message at a time
* Optionally show dialog for error messages
* Fix circular dependency
* Animate toast
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Something needed tweaking.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve Toast positioning
2 participants