Added Sort Performers by Last O At / Last Played At / Play Count and Added Filter Performers by Play Count. Changes to display O Count rather than O-Counter for better consistency. Grammar fixes for 'Interactive Speed' and 'pHash'. #4649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added 2 New Sorts 'Last O At' and 'Last Played At' for Performers
Was not sure whether to label this 'views' as the code does, or 'plays' but chose the latter as it gives parity across the scenes and performers filters.
Reutilised the prior selectPerformerLastOAtSQL code that was used to filter by play count to additionally provide useful sorting options.
To better match other sort and filter options like Gallery Count, Image Count, Play Count, Scene Count, Tag Count, File Count, Performer Count and Play Count, we should really use O Count rather than O-Counter for increased legibility and coherence.
Every other filter/sort option is using Title Case other than 'Interactive speed' which stands out as incorrect. Also, fixing the correct mid-word capitalization on phash to pHash.
Formatted source code and Ran all tests
WithoutPants
added
feature
8 tasks
halkeye
pushed a commit
to halkeye/stash
that referenced
this pull request
Sep 1, 2024
…Added Filter Performers by Play Count. Changes to display O Count rather than O-Counter for better consistency. Grammar fixes for 'Interactive Speed' and 'pHash'. (stashapp#4649) * Sort Performers by Last O / View Added 2 New Sorts 'Last O At' and 'Last Played At' for Performers * Filter Performers by Play Count Was not sure whether to label this 'views' as the code does, or 'plays' but chose the latter as it gives parity across the scenes and performers filters. * Sort Performers by Play Count Reutilised the prior selectPerformerLastOAtSQL code that was used to filter by play count to additionally provide useful sorting options. * Replaced O-Counter with O Count To better match other sort and filter options like Gallery Count, Image Count, Play Count, Scene Count, Tag Count, File Count, Performer Count and Play Count, we should really use O Count rather than O-Counter for increased legibility and coherence. * Title Case on 'Interactive speed' and correct capitalization for 'phash' Every other filter/sort option is using Title Case other than 'Interactive speed' which stands out as incorrect. Also, fixing the correct mid-word capitalization on phash to pHash. * Formatting Formatted source code and Ran all tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds the option to sort (and filter) the performer page by recent activity, which can provide interesting and more dynamic arrangements compared to the static values such as height. I first added options to sort them by Last O At and Last Played At, to compliment the same set of options now available in scenes.
While I could filter the 'Last O At' performers with an 'O Count Greater than Zero' to better sort the results by ascending/descending, it was not possible to do the same with the 'Last Played At' performers, so I felt it necessary to include the option to filter performers by Play Count as well.
The only thing still missing from these additions, taking advantage of the full parity between the new Play/O date data, was the option to sort Performers by Play Count so I've added that as well. As users build up more of a long-term view/o-history the benefits of these additional sorts and filters should become clear.
The O-Counter text has been changed to 'O Count', as it makes for far more legibility and coherence if it matches the other sort and filter options it is placed alongside, like Gallery Count, Image Count, Play Count, Scene Count, Tag Count, File Count and Performer Count. I kept the O-Counter hover text for the literal O-Counter button but have changed it first in the sort/filter then where I could additionally find it, in two list tables and the merge scene dialogue.
Finally, I had to fix a couple of things that now looked out of place in the beautiful cleaner sort list - using Title Case capitalization for 'Interactive speed' to match the other sort/filter text and using the correct mid-word capitalization for pHash.