Scan video orientation #5189
Merged
Scan video orientation #5189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #4738
Resolves #3479
Supersedes #4781
Determines if the orientation of videos are rotated during scanning to correct the dimensions.
It has a negligible performance impact on video file scanning.
It does require ffprobe 5.x and above, so I've added version parsing to ffprobe, and the orientation detection will only be included if ffprobe version is compatible. I've also added a warning a startup to indicate if ffmpeg needs to be updated. In future I think we'll want to inform the user in the UI.