Ulc/rewiew update #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JekaMas
approved these changes
Jul 9, 2018
zsfelfoldi
suggested changes
Jul 9, 2018
les/fetcher.go
Outdated
| if canonical.Number.Uint64() > f.lastTrustedHeader.Number.Uint64() { | ||
| canonical = f.chain.GetHeaderByNumber(f.lastTrustedHeader.Number.Uint64()) | ||
| } | ||
| ancestorHash := rawdb.FindCommonAncestor(f.pm.chainDb, canonical, f.lastTrustedHeader).Hash() |
There was a problem hiding this comment.
I did not write this in my previous review but I'd add a check to avoid panic if the common ancestor header is nil. In that case print an error log.
les/fetcher.go
Outdated
| canonical = f.chain.GetHeaderByNumber(f.lastTrustedHeader.Number.Uint64()) | ||
| } | ||
| ancestorHash := rawdb.FindCommonAncestor(f.pm.chainDb, canonical, f.lastTrustedHeader).Hash() | ||
| for current.Hash() != f.lastTrustedHeader.Hash() || current.Hash() != ancestorHash { |
There was a problem hiding this comment.
This condition does not make sense. Maybe you wanted to use &&.
les/fetcher.go
Outdated
| } | ||
| ancestorHash := rawdb.FindCommonAncestor(f.pm.chainDb, canonical, f.lastTrustedHeader).Hash() | ||
| for current.Hash() != f.lastTrustedHeader.Hash() || current.Hash() != ancestorHash { | ||
| if current == nil { |
There was a problem hiding this comment.
This check does not make sense here, current.Hash() would have already panic-ed if current is nil. Check it at the end, after loading the new value.
b00ris
force-pushed
the
ulc/rewiew_update
branch
from
1dbeecd
to
89daab4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.