Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

terraform: add boot nodes #4

Merged
merged 2 commits into from
Sep 19, 2023
Merged

terraform: add boot nodes #4

merged 2 commits into from
Sep 19, 2023

Conversation

yakimant
Copy link
Member

@yakimant yakimant commented Sep 18, 2023 •
edited by jakubgs
Loading

@yakimant yakimant mentioned this pull request Sep 18, 2023
Closed
@yakimant yakimant changed the title Add boot nodes terraform: add boot nodes Sep 18, 2023
jakubgs
jakubgs approved these changes Sep 18, 2023
View reviewed changes
Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to rebase before merging.

@yakimant yakimant merged commit 4fb5429 into master Sep 19, 2023
@yakimant
Copy link
Member Author

Hm, rebasing the PR branch with master didn't do anything and PR still has 2 commits attached. Maybe not supported GitHub flow..

@jakubgs jakubgs deleted the add_boot_nodes branch September 19, 2023 10:33
@jakubgs
Copy link
Member

jakubgs commented Sep 19, 2023

Are you sure you pushed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubgs jakubgs jakubgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yakimant @jakubgs