Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discv5 factorize #480

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Discv5 factorize #480

wants to merge 13 commits into from

Commits on Feb 22, 2022

  1. move message encoding to separate file

    Messages and message encoding has nothing
    to do with the underlying authenticated
    communications framework. Separate these
    two.
    cskiraly committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    083e185 View commit details
    Browse the repository at this point in the history
  2. splitting protocol in lower and upper half

    Protocol was actually made of two sub-protocols.
      * a lower-half handling authentication, encryption,
    key exchange, and request/response. This is now called
    Transport.
      * an upper-half handling DHT messages. This is still
    called Protocol.
    
    Separation of these two reduces dependencies and simplifies
    modifications to the protocol.
    Signed-off-by: Csaba Kiraly <[email protected]>
    cskiraly committed Feb 22, 2022
    Configuration menu
    Copy the full SHA
    a99cafa View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2022

  1. fixup: fix imports in test_discoveryv5_encoding

    Note that the test does not compile, but it was
    also not compiling before
    
    Signed-off-by: Csaba Kiraly <[email protected]>
    cskiraly committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    f49801e View commit details
    Browse the repository at this point in the history
  2. attempt to clean up send proc names

    - interface between Transport and Protocol is at the encoded Message
    level
    cskiraly committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    0843ea9 View commit details
    Browse the repository at this point in the history
  3. transport.sendMessage: avoid passing address twice

    Node already has the address, so it does not make sense to
    pass it as a separate parameter.
    cskiraly committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    9b86ade View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7f1fd9f View commit details
    Browse the repository at this point in the history
  5. rename protocol.sendMessage to sendRequest

    This is a request part of a Request/Response, generating
    also a reques ID. So call it what it is.
    cskiraly committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    29584e1 View commit details
    Browse the repository at this point in the history
  6. protocol: introduce sendResponse

    This completes the Request/Response semantics.
    cskiraly committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    0d0b7ad View commit details
    Browse the repository at this point in the history
  7. utp_discv5: use protocol.sendRequest

    It is better to rely on protocol.nim to do all the encoding,
    thus cleaning up dependencies.
    cskiraly committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    c923a76 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6b6146e View commit details
    Browse the repository at this point in the history
  9. fixup: fix trace message

    cskiraly committed Feb 23, 2022
    Configuration menu
    Copy the full SHA
    354165b View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2022

  1. Configuration menu
    Copy the full SHA
    cd848a8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    99fc5fd View commit details
    Browse the repository at this point in the history