-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Discv5 factorize #480
base: master
Are you sure you want to change the base?
Discv5 factorize #480
Commits on Feb 22, 2022
-
move message encoding to separate file
Messages and message encoding has nothing to do with the underlying authenticated communications framework. Separate these two.
Configuration menu - View commit details
-
Copy full SHA for 083e185 - Browse repository at this point
Copy the full SHA 083e185View commit details -
splitting protocol in lower and upper half
Protocol was actually made of two sub-protocols. * a lower-half handling authentication, encryption, key exchange, and request/response. This is now called Transport. * an upper-half handling DHT messages. This is still called Protocol. Separation of these two reduces dependencies and simplifies modifications to the protocol. Signed-off-by: Csaba Kiraly <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a99cafa - Browse repository at this point
Copy the full SHA a99cafaView commit details
Commits on Feb 23, 2022
-
fixup: fix imports in test_discoveryv5_encoding
Note that the test does not compile, but it was also not compiling before Signed-off-by: Csaba Kiraly <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f49801e - Browse repository at this point
Copy the full SHA f49801eView commit details -
attempt to clean up send proc names
- interface between Transport and Protocol is at the encoded Message level
Configuration menu - View commit details
-
Copy full SHA for 0843ea9 - Browse repository at this point
Copy the full SHA 0843ea9View commit details -
transport.sendMessage: avoid passing address twice
Node already has the address, so it does not make sense to pass it as a separate parameter.
Configuration menu - View commit details
-
Copy full SHA for 9b86ade - Browse repository at this point
Copy the full SHA 9b86adeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f1fd9f - Browse repository at this point
Copy the full SHA 7f1fd9fView commit details -
rename protocol.sendMessage to sendRequest
This is a request part of a Request/Response, generating also a reques ID. So call it what it is.
Configuration menu - View commit details
-
Copy full SHA for 29584e1 - Browse repository at this point
Copy the full SHA 29584e1View commit details -
protocol: introduce sendResponse
This completes the Request/Response semantics.
Configuration menu - View commit details
-
Copy full SHA for 0d0b7ad - Browse repository at this point
Copy the full SHA 0d0b7adView commit details -
utp_discv5: use protocol.sendRequest
It is better to rely on protocol.nim to do all the encoding, thus cleaning up dependencies.
Configuration menu - View commit details
-
Copy full SHA for c923a76 - Browse repository at this point
Copy the full SHA c923a76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6b6146e - Browse repository at this point
Copy the full SHA 6b6146eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 354165b - Browse repository at this point
Copy the full SHA 354165bView commit details
Commits on Feb 24, 2022
-
Configuration menu - View commit details
-
Copy full SHA for cd848a8 - Browse repository at this point
Copy the full SHA cd848a8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99fc5fd - Browse repository at this point
Copy the full SHA 99fc5fdView commit details