Skip to content

Commit

Permalink
Add build test with chronicles to json enabled (#215)
Browse files Browse the repository at this point in the history
* Add build test with chronicles to json enabled

* Fix windows failing test
  • Loading branch information
jangko committed Feb 19, 2024
1 parent 514049a commit 9c65df3
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 11 deletions.
18 changes: 8 additions & 10 deletions json_rpc.nimble
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,14 @@ proc run(args, path: string) =
if (NimMajor, NimMinor) > (1, 6):
build args & " --mm:refc -r", path

proc buildBinary(name: string, srcDir = "./", params = "", cmdParams = "") =
if not dirExists "build":
mkDir "build"
exec "nim " & getEnv("TEST_LANG", "c") & " " & getEnv("NIMFLAGS") &
" -r -f --skipUserCfg:on --skipParentCfg:on --verbosity:0" &
" --debuginfo --path:'.' --threads:on -d:chronicles_log_level=ERROR" &
" --styleCheck:usages --styleCheck:hint" &
" --hint[XDeclaredButNotUsed]:off --hint[Processing]:off " &
" --out:./build/" & name & " " & params & " " & srcDir & name & ".nim" &
" " & cmdParams
proc buildOnly(args, path: string) =
build args, path
if (NimMajor, NimMinor) > (1, 6):
build args & " --mm:refc -r", path

task test, "run tests":
run "", "tests/all"

when not defined(windows):
# on windows, socker server build failed
buildOnly "-d:\"chronicles_sinks=textlines[dynamic],json[dynamic]\"", "tests/all"
2 changes: 1 addition & 1 deletion json_rpc/clients/socketclient.nim
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ proc processData(client: RpcSocketClient) {.async: (raises: []).} =

# async loop reconnection and waiting
try:
info "Reconnect to server", address=client.address
info "Reconnect to server", address=`$`(client.address)
client.transport = await connect(client.address)
except TransportError as exc:
error "Error when reconnecting to server", msg=exc.msg
Expand Down

0 comments on commit 9c65df3

Please sign in to comment.