Use JsonRpcError instead of ValueError #151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows implementors of this library to distinguish between errors originating from this library.
|
There are a a lot more random errors coming out from practically any call in here (chronos, json parsing etc) - will need to do be a lot more thorough if you want to narrow down the exceptions in here - ie practically every line in the library needs to live in a try/catch with an error conversion |
|
@emizzle this is still a valuable change - will you be getting back to it? |
|
close in favor of #178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows implementors of this library to distinguish between errors originating from this library.
Likely a breaking change for current users.