Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some minimal changes to be able to base the nimlangserver in json_rpc #222

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

jmgomez
Copy link
Contributor

@jmgomez jmgomez commented Jul 17, 2024

  • processClientHook: This is useful to shape the request and response to defined protocols (i.e. lsp)
  • overloads tryRoute: So it doesnt parse the json inside.

This is useful to shape the request and response to defined protocols (i.e. lsp)
@jmgomez
Copy link
Contributor Author

jmgomez commented Jul 20, 2024

Failures seem unrelated cc @arnetheduck

tests/testserverclient.nim Outdated Show resolved Hide resolved
json_rpc/router.nim Show resolved Hide resolved
@jmgomez jmgomez requested a review from jangko July 22, 2024 09:51
@jangko jangko merged commit e27c10a into status-im:master Jul 23, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants