Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug/Fuzzing] Incorrect validation of pre-state attestation & malformed block signature during state transition (nim) #944

Closed
pventuzelo opened this issue Apr 28, 2020 · 1 comment

Comments

@pventuzelo
Copy link

Hi guys,

After fuzzing with beacon-fuzz, we found an issue in prysm and I reported it here:
[bug/fuzzing] Incorrect validation of pre-state attestation & malformed block signature during state transition.

Download: incorrect_ssz_validation_prysm.zip

Based on testing with ./ncli_transition, you also have the same issues:

$ make

$ cd ncli

$ ../env.sh nim c -d:const_preset=mainnet ncli_transition

$ ./ncli_transition --pre= incorrect_ssz_validation_state_prysm.ssz --blck= incorrect_ssz_validation_block_prysm.ssz --post= post.ssz
...
# process continued without any errors

Environment

preset: mainnet preset
branch: devel
commit: fada11e

@pventuzelo pventuzelo changed the title [bug/Fuzzing] Incorrect validation of pre-state attestation & malformed block signature during state transition [bug/Fuzzing] Incorrect validation of pre-state attestation & malformed block signature during state transition (nim) Apr 28, 2020
tersec added a commit that referenced this issue Apr 30, 2020
tersec added a commit that referenced this issue Apr 30, 2020
@tersec
Copy link
Contributor

tersec commented May 6, 2020

According to discussion from #955 it's not clear we'll fix this as such. I'll leave this open for now, pending further discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants